Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make doesn't fail on error #1224

Open
marcinkubica opened this issue Dec 23, 2022 · 0 comments
Open

Make doesn't fail on error #1224

marcinkubica opened this issue Dec 23, 2022 · 0 comments
Labels

Comments

@marcinkubica
Copy link
Contributor

Make doesn't fail on error

It appears make doesn't fail on error for Github Actions

Run make build
  make build
  shell: /usr/bin/bash -e {0}
  env:
    DB_DATABASE: autoscaler
    DB_USER: postgres
    DB_PASSWORD: postgres
    MAVEN_VERSION: 3.6.3
    MAVEN_SHA: c35a1803a6e70a1[2](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:2)6e80b2b[3](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:3)ae33eed961f83ed7[4](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:4)d18fcd16909b2d44d7dada3203f1ffe726c17ef8dcca2dcaa9fca676987befeadc9b9f7[5](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:5)99[6](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:6)[7](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:7)a[8](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:8)cb77181c0
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.5-8/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.5-8/x64
/bin/bash: line 1: ginkgo: command not found
# Installing build tools
# building api
# building eventgenerator

Your environment

Current ubuntu-latest job
Please see workflow log

Fixes

Problem doesn't appear when using app-autoscaler-release-tools image (since ginkgo is present there) however the issue not failing the workflow persist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant