Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf apply should use the corresponding plan file from tf plan #741

Open
tammersaleh opened this issue May 21, 2020 · 0 comments
Open

tf apply should use the corresponding plan file from tf plan #741

tammersaleh opened this issue May 21, 2020 · 0 comments

Comments

@tammersaleh
Copy link
Contributor

This came out of the cg-provision meeting on May 21st

Our cg-provision pipeline (also aws-broker and maybe others) is configured to run terraform plan, and in a later job run terraform apply. However, that apply doesn't make use of a saved plan file. This means infrastructure drift during plan review and before the apply job is triggered can result in unexpected and possibly destructive changes.

Instead, we should save the plan output from the terraform plan job and make use of it in the apply job.

options:

  • Switch to using a different tf resource that saves the plan?
  • Modify our tf task to upload plan to S3 and pass it to the apply stage?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant