Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor keys to avoid duplicate string literals #255

Open
neob91-close opened this issue Dec 14, 2022 · 0 comments · May be fixed by #309
Open

Refactor keys to avoid duplicate string literals #255

neob91-close opened this issue Dec 14, 2022 · 0 comments · May be fixed by #309

Comments

@neob91-close
Copy link
Contributor

neob91-close commented Dec 14, 2022 •
edited

We're currently using a lot of string literals for building Redis keys, and it's relatively easy to make a typo that might go unnoticed.

It would be nice if we could improve on this.

Maybe use a separate method for generating each key?
Or perhaps simply use constants instead of literals such as "task" or "executions", the way we already do for QUEUED, SCHEDULED, etc.?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Redis keys to avoid duplicate string literals vishesh10/tasktiger
1 participant
@neob91-close