Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize task args & kwargs for uniqueness/locking #159

Open
thomasst opened this issue Mar 9, 2020 · 0 comments
Open

Normalize task args & kwargs for uniqueness/locking #159

thomasst opened this issue Mar 9, 2020 · 0 comments

Comments

@thomasst
Copy link
Member

thomasst commented Mar 9, 2020

As @wojcikstefan pointed out, a task t(x) would have a different ID used for uniqueness and locking depending on whether it was used queued as t(x=1) or t(1), since the arg would either be in args or in kwargs.

This applies to unique and lock_key (see e.g. https://github.com/closeio/tasktiger/blob/master/tasktiger/worker.py#L820-L825).

We should find a way to normalize the task lock IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant