Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Google events sync has a channel token #2

Open
lmickh opened this issue Jul 19, 2019 · 0 comments
Open

Ensure Google events sync has a channel token #2

lmickh opened this issue Jul 19, 2019 · 0 comments

Comments

@lmickh
Copy link
Contributor

lmickh commented Jul 19, 2019

I cannot find where we enable the Google channel token header in the webhooks or validate it. The option is off by default. Do we know that we are setting it? If not, we should enable it since it is effectively the password to the corresponding channel id.

Related code:
https://github.com/closeio/nylas/blob/n17/inbox/events/remote_sync.py
https://github.com/closeio/nylas/blob/n17/inbox/events/google.py

Information about the id and token headers can be found here:
https://developers.google.com/calendar/v3/push#understanding-the-notification-message-format

@lmickh lmickh changed the title Ensure Google events sync is not missing a token Ensure Google events sync has a channel token Jul 19, 2019
@jpmelos jpmelos transferred this issue from closeio/nylas Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant