Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer logging of the account ID responsible for a blocking greenlet #18

Open
wojcikstefan opened this issue Aug 3, 2020 · 0 comments

Comments

@wojcikstefan
Copy link
Member

When processing of an account blocks other greenlets, we log a warning about it here:

self.log.warning(
'greenlet blocking', frame=formatted_frame,
context=getattr(active_greenlet, 'context', None),
blocking_greenlet_id=id(active_greenlet))

An example of a context logged is foldersyncengine:26:60 where 26 corresponds to the ID of the account being processed. I suggest that, instead of logging an enigmatic context, we should log an explicit account_id=context.split(':')[1] in this warning. I did NOT confirm that the format of the context is always the same though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant