Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove javadoc fallback #160

Closed
vemv opened this issue May 18, 2022 · 5 comments
Closed

Remove javadoc fallback #160

vemv opened this issue May 18, 2022 · 5 comments

Comments

@vemv
Copy link
Member

vemv commented May 18, 2022

(javadoc-base-urls 11))))))

11 isn't a special JDK and defaulting to it can mask issues (especially as we complete and enable enrich-classpath)

@bbatsov
Copy link
Member

bbatsov commented Sep 3, 2022

Isn't this unrelated to to what enrich-classpath does? It simply computes the URL for the remote JavaDoc. I think 11 was the newest LTS when this was written, that's why it was the default.

@vemv
Copy link
Member Author

vemv commented Sep 3, 2022

But 11 (or any single choice) isn't accurate, also can lack results for the newer classes that can get added for each JDK.

When enrich-classpath gets its finishing touch I'd feel more comfortable tweaking this section of code.

@bbatsov
Copy link
Member

bbatsov commented Sep 3, 2022

Yeah, that's fair. Frankly, I'm not sure in which case java-api-version might return nil to begin with. I guess this fallback simply guards against this case.

@alexander-yakushev
Copy link
Member

This was addressed in bb22fb3, right?

@vemv
Copy link
Member Author

vemv commented May 7, 2024

SGTM. We don't give a lot of uses to javadoc anyway

clojure-emacs/cider#3575

@vemv vemv closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants