Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code complete don't support plain js object #23

Open
shaqtsui opened this issue Nov 7, 2017 · 4 comments
Open

code complete don't support plain js object #23

shaqtsui opened this issue Nov 7, 2017 · 4 comments

Comments

@shaqtsui
Copy link

shaqtsui commented Nov 7, 2017

When type:
(js/THR

Expected complete list:
(js/THREE
...

I think a enhancement required here

@arichiardi
Copy link
Contributor

This is something that has been done in lumo and can be easily ported over: https://github.com/anmonteiro/lumo/blob/master/src/cljs/snapshot/lumo/repl.cljs#L1297-L1320

@arichiardi
Copy link
Contributor

Not easily 😄 it looks like the implementation is Clojure for vanilla JVM so the above code would only work for self-hosted REPLs

@cichli
Copy link
Member

cichli commented Jan 19, 2019

For the JVM side we can implement this once CLJS-1047 is done. Feel free to vote on that ticket if you're registered on JIRA.

I'm not sure what makes most sense for the self-host case but what Lumo does with completion-candidates-for-node-modules and completion-candidates-for-closure-js looks sane. Maybe we should port that over.

@rksm
Copy link
Member

rksm commented Aug 9, 2019

FYI this has been implemented here https://github.com/rksm/clj-suitable but uses dynamic runtime inspection and not static code analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants