Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the nrepl.middleware.print/quota for interactive eval #3633

Open
vemv opened this issue Mar 14, 2024 · 0 comments · May be fixed by #3635
Open

Reduce the nrepl.middleware.print/quota for interactive eval #3633

vemv opened this issue Mar 14, 2024 · 0 comments · May be fixed by #3635
Assignees

Comments

@vemv
Copy link
Member

vemv commented Mar 14, 2024

When doing interactive eval, the result will generally be displayed inline in the current buffer, as an overlay (there's the exception of the output-to-current-buffer arg).

So the default quota of 1MB is excessive there, as we never possibly want to render 1MB worth of output in the current buffer.

(There's client-side trimming, but we shouldn't overload it trivially)

The quota should be limited to appoximately one screenful worth of characters, give or take - can be discussed at PR time.

@vemv vemv self-assigned this Mar 14, 2024
@vemv vemv linked a pull request Mar 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant