Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exceptions] Potential improvement for *cider-error* buffers #1929

Closed
harold opened this issue Jan 26, 2017 · 7 comments
Closed

[exceptions] Potential improvement for *cider-error* buffers #1929

harold opened this issue Jan 26, 2017 · 7 comments

Comments

@harold
Copy link
Contributor

harold commented Jan 26, 2017

Prone is a helpful library for debugging clojure/ring web applications.

A great feature of Prone is their display of stack traces, a lot of typically useless and distracting information is elided. I was reading about how they achieved that:
https://github.com/magnars/prone#how-does-prone-determine-what-parts-of-a-stack-trace-belongs-to-the-application

(they do some sort of filtering on the namespaces)

I wonder if something similar would be possible/good in Cider? The existing stacktrace/error functionality is sophisticated, useful, and a key part of my day to day work already; but I think additional filtering could still help.

Thanks again for Cider, I can't mention enough how lovely and great it is.

@bbatsov
Copy link
Member

bbatsov commented Jan 26, 2017

Basically you want some toggle that just displays only the application stack frames?

@harold
Copy link
Contributor Author

harold commented Jan 26, 2017

Basically you want some toggle that just displays only the application stack frames?

Yes: filtering out libraries and clojure/core, etc. Does that sound right to you?

@bbatsov
Copy link
Member

bbatsov commented Jan 26, 2017

Yeah, it does. As we already have a filtering mechanism in place I'm assuming that extending it to account just for application frames should be easy.

@dpsutton
Copy link
Contributor

The pull request to cider-nrepl above will flag frames with 'project.

Adding a filter in the method of the others does not accomplish what we want though. They are negative filters in the sense that they remove frames marked with the symbol given. We need a different notion of a filter that removes the complement of the button hit. Shouldn't be hard but doesn't just plug right in. I'll get on this as soon as the clojure side pull request is up to snuff and accepted.

@harold
Copy link
Contributor Author

harold commented Apr 10, 2017

Mmm, I like where this is headed. Let me know if there's more I can do to help.

@xiongtx
Copy link
Member

xiongtx commented Mar 14, 2018

@dpsutton Hasn't the "negative" filter been implemented as Show instead of Hide?

image

@harold Can this be closed? Or do you have some other filters in mind?

@harold
Copy link
Contributor Author

harold commented Mar 14, 2018

Woah. I just clicked Project-Only for the first time, and good things happened! Great work, all.

I will experiment with this more in more real-world use and see how it goes.

I have no problem closing this, future thoughts can be put into new issues.

Thanks again all.

@xiongtx xiongtx closed this as completed Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants