-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exceptions] Potential improvement for *cider-error*
buffers
#1929
Comments
Basically you want some toggle that just displays only the application stack frames? |
Yes: filtering out libraries and clojure/core, etc. Does that sound right to you? |
Yeah, it does. As we already have a filtering mechanism in place I'm assuming that extending it to account just for application frames should be easy. |
The pull request to cider-nrepl above will flag frames with 'project. Adding a filter in the method of the others does not accomplish what we want though. They are negative filters in the sense that they remove frames marked with the symbol given. We need a different notion of a filter that removes the complement of the button hit. Shouldn't be hard but doesn't just plug right in. I'll get on this as soon as the clojure side pull request is up to snuff and accepted. |
Mmm, I like where this is headed. Let me know if there's more I can do to help. |
Woah. I just clicked I will experiment with this more in more real-world use and see how it goes. I have no problem closing this, future thoughts can be put into new issues. Thanks again all. |
Prone is a helpful library for debugging clojure/ring web applications.
A great feature of Prone is their display of stack traces, a lot of typically useless and distracting information is elided. I was reading about how they achieved that:
https://github.com/magnars/prone#how-does-prone-determine-what-parts-of-a-stack-trace-belongs-to-the-application
(they do some sort of filtering on the namespaces)
I wonder if something similar would be possible/good in Cider? The existing stacktrace/error functionality is sophisticated, useful, and a key part of my day to day work already; but I think additional filtering could still help.
Thanks again for Cider, I can't mention enough how lovely and great it is.
The text was updated successfully, but these errors were encountered: