Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-nrepl:jar:0.14.0-SNAPSHOT missing? #1816

Closed
vijaykiran opened this issue Jul 28, 2016 · 9 comments
Closed

cider-nrepl:jar:0.14.0-SNAPSHOT missing? #1816

vijaykiran opened this issue Jul 28, 2016 · 9 comments

Comments

@vijaykiran
Copy link

Expected behavior

cider-jack-in should work.

Actual behavior

Fails with
Could not find artifact cider:cider-nrepl:jar:0.14.0-SNAPSHOT in clojars (https://clojars.org/repo/)

Steps to reproduce the problem

  • Update to latest packages in Emacs (not the pinned packages)
  • Open any clojure file
  • And M-x cider-jack-in

Environment & Version information

CIDER version information

CIDER 0.14.0snapshot (package: 20160727.904)

Emacs version

GNU Emacs 25.1.1 (x86_64-apple-darwin15.6.0, Carbon Version 157 AppKit 1404.47) of 2016-07-25

Operating system

OS X 10.11 "El Capitan"

@Malabarba
Copy link
Member

I haven't configure my clojars credentials here at work yet. But I can push the snapshot tonight if @bbatsov doesn't get to it first.

@dpsutton
Copy link
Contributor

Is this an argument to switch to a more git-flow style of development? Since this was a commit on master, it allowed people to update on elpa. At work we work off of develop, and the only commits to master (aside from hot fixes) are releases. You can still merge develop into master periodically to give people snapshot builds, but it would prevent updates for each and every commit, and possibly broken ones like this?

@Malabarba
Copy link
Member

Malabarba commented Jul 28, 2016

However, this didn't happen because of some random commit. This happened because of this commit which specifically bumps the injected version to be 0.14.0-snapshot.

@dpsutton
Copy link
Contributor

Yeah. That's what I meant. It was a commit that was purely for devs, not to be released. But since it was on master many people saw an updgrade to cider and upgraded, rendering their cider packages broken. If this was done on the develop branch, no such release on melpa would have occured, and development for CIDER devs would have been unaffected.

@Malabarba
Copy link
Member

@bbatsov just got distracted and forgot to do the same for cider-nrepl, which needs to be done at the same time regardless of our release workflow (he's a busy guy :-).
It's not a commit for developers, it's just a completely broken commit as is. :-)

@Malabarba
Copy link
Member

Also, changing to a dev branch would sort of just reimplement the advantages of Melpa.
We have stable releases on Melpa-stable. Melpa is for snapshots and will break occasionally.

@bcarrell
Copy link

Until one of the maintainers pushes a new version to Clojars, keep in mind the workaround is to essentially:

git clone https://github.com/clojure-emacs/cider-nrepl.git
cd cider-nrepl
lein install

Hope that helps.

@expez
Copy link
Member

expez commented Jul 30, 2016

https://clojars.org/cider/cider-nrepl/versions/0.14.0-SNAPSHOT

@expez expez closed this as completed Jul 30, 2016
@Malabarba
Copy link
Member

Thanks @expez. Good to know at least one of us hasn't forgotten how to push a clojar. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants