Different behaviour for re-matches

[jfacorro]

Describe the bug
The implementation of re-matches and re-find for Clojure in the JVM relies on the underlying java.util.regex.Matcher class which provides the matches() and find() methods.

The main difference between these two is that matches() tries to match the whole string. The Clojerl implementation for re-matches makes use of re-find and checks that the first item returned is equal to the provided string (i.e. the whole input was matched). This approach works fine for most regular expressions, but there are cases where this does not work.

To Reproduce

(re-matches #"(.*)\$(.*?)(__[0-9]+)?" "user$eval140$fn__141")

Expected behavior

user=> (re-matches #"(.*)\$(.*?)(__[0-9]+)?" "user$eval140$fn__141")
["user$eval140$fn__141" "user$eval140" "fn" "__141"]

Actual behavior

clje.user=> (re-matches #"(.*)\$(.*?)(__[0-9]+)?" "user$eval140$fn__141")
nil

We can get the same behaviour in Clojerl if we add a $ at the end of the regex above:

clje.user=> (re-matches #"(.*)\$(.*?)(__[0-9]+)?$" "user$eval140$fn__141")
["user$eval140$fn__141" "user$eval140" "fn" "__141"]

But this is not what users should need to do.

Context

• clojerl version (tag/sha): 0.7.1-69-g74b5d70