Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELECT * FROM * no longer allowed in subscriptions #1199

Closed
gefjon opened this issue May 3, 2024 · 4 comments · Fixed by #1218
Closed

SELECT * FROM * no longer allowed in subscriptions #1199

gefjon opened this issue May 3, 2024 · 4 comments · Fixed by #1218
Labels
api-break A PR that breaks some user-visible API bug Something isn't working

Comments

@gefjon
Copy link
Contributor

gefjon commented May 3, 2024

Errors with Unsupported query on subscription: "Multiple statements in subscription query".

Should also add a test to the SDK tests which exercises this.

@gefjon gefjon added bug Something isn't working api-break A PR that breaks some user-visible API labels May 3, 2024
@gefjon
Copy link
Contributor Author

gefjon commented May 3, 2024

Likely the path of least resistance here is, instead of recognizing SELECT * FROM * in the SQL compiler, detecting it earlier when parsing the Subscribe message and invoking a separate compilation path.

@joshua-spacetime
Copy link
Collaborator

I know we need to support this for the time being, but we should probably reconsider whether we want to support it for 1.0. It's a useful utility, but technically it's not valid SQL.

@gefjon
Copy link
Contributor Author

gefjon commented May 13, 2024

I added a test for this to the branch phoebe/select-star-broken, but am now going to do by very best to find someone who isn't me to fix it.

@Centril
Copy link
Contributor

Centril commented May 13, 2024

cc #1220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that breaks some user-visible API bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants