Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine reducer and incremental update duration metrics #1168

Closed
joshua-spacetime opened this issue Apr 26, 2024 · 3 comments · Fixed by #1195
Closed

Combine reducer and incremental update duration metrics #1168

joshua-spacetime opened this issue Apr 26, 2024 · 3 comments · Fixed by #1195
Assignees

Comments

@joshua-spacetime
Copy link
Collaborator

Right now reducer durations and incremental update durations are tracked using two different metrics. We should also have a metric that combines them since a reducer call and an incremental update are logically an atomic unit of execution.

This will give users additional observability into their reducers as they'll be able to see which reducers have more expensive incremental updates.

Note this will be a natural fallout of #1157 since both will be executed as part of the same transaction, but we'll want to make sure to maintain the separated metrics as well.

@joshua-spacetime joshua-spacetime self-assigned this Apr 26, 2024
@Shubham8287
Copy link
Contributor

I think this is the combined metrics that we already have -

?

@joshua-spacetime
Copy link
Collaborator Author

@Shubham8287 I'd like to only account for transaction processing time vs the entire time spent on the server. I believe that metric tracks the latter, although correct me if I'm wrong.

@Shubham8287
Copy link
Contributor

@Shubham8287 I'd like to only account for transaction processing time vs the entire time spent on the server. I believe that metric tracks the latter, although correct me if I'm wrong.

You are right, this metric measure entier time spent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants