Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks don't work. #3

Open
danem opened this issue Oct 2, 2017 · 3 comments
Open

Permalinks don't work. #3

danem opened this issue Oct 2, 2017 · 3 comments

Comments

@danem
Copy link

danem commented Oct 2, 2017

See:

https://news.ycombinator.com/item?id=15380658

vs

http://www.hnclone.win/item?id=15380658

@clintonwoo
Copy link
Owner

clintonwoo commented Oct 2, 2017

Hm that's strange. I didn't think this would happen but it's probably a small change. A pull request is welcome otherwise I'll take a look later.

Edit: I had a look and it's just that the page to view a comment instead of a news item hasn't been completed

Edit 2: It's because comments and news items are fetched on the same url. The app throws an error if a news item doesn't have a Title (because comments don't have those)

@jsainthilaire
Copy link

@clintonwoo I will take over this issue if that's ok with you.

@clintonwoo
Copy link
Owner

@jsainthilaire sure thing mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants