Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to get genegraph UI and genegraph on the same hostname for CORS purposes #263

Open
sjahl opened this issue Feb 14, 2022 · 0 comments
Assignees
Labels

Comments

@sjahl
Copy link
Contributor

sjahl commented Feb 14, 2022

See: https://clingen.slack.com/archives/C01S7GH0GJF/p1644346884505619

In environments that MITM you and inject CORS headers on http responses, it's problematic to have genegraph-ui being served from a different hostname than genegraph.

I'm not 100% on this yet, but GKE Ingress supports the use of cloud CDN, so we may be able to achieve this by using that.

https://cloud.google.com/kubernetes-engine/docs/how-to/ingress-features

Some quick searches indicate that there's some performance considerations: https://blog.yongweilun.me/gke-ingress-is-slower-than-you-think

@sjahl sjahl added the sre label Feb 14, 2022
@sjahl sjahl self-assigned this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant