You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several places in the codebase where the length of the solar year is hard-coded to the value given by
climlab.utils.constants.days_per_year
This creates challenges particularly for modeling planetary atmospheres.
Related to #120, it would be good to have the option to modify this.
I hacked up some fixes that seem to work (not currently in a PR):
provide an optional days_per_year argument to the climlab.solar.insolation.daily_insolation() function (and pass this in the internal call to climlab.solar.insolation.solar_longitude(), which already accepts this argument
Add a .days_per_year attribute to the TimeDependentProcess class (which defaults to the standard Earth value)
Use this value in the timestep.setter method
Modify the DailyInsolation class to use the stored days_per_year value
Maybe it would be best to continue to pursue a general solution to #120, which I started to hack up in #123
The text was updated successfully, but these errors were encountered:
There are several places in the codebase where the length of the solar year is hard-coded to the value given by
This creates challenges particularly for modeling planetary atmospheres.
Related to #120, it would be good to have the option to modify this.
I hacked up some fixes that seem to work (not currently in a PR):
days_per_year
argument to theclimlab.solar.insolation.daily_insolation()
function (and pass this in the internal call toclimlab.solar.insolation.solar_longitude()
, which already accepts this argument.days_per_year
attribute to theTimeDependentProcess
class (which defaults to the standard Earth value)timestep.setter
methodDailyInsolation
class to use the storeddays_per_year
valueMaybe it would be best to continue to pursue a general solution to #120, which I started to hack up in #123
The text was updated successfully, but these errors were encountered: