Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations for ARIA attributes & image alt text #126

Open
clhenrick opened this issue Nov 28, 2023 · 0 comments
Open

Add missing translations for ARIA attributes & image alt text #126

clhenrick opened this issue Nov 28, 2023 · 0 comments

Comments

@clhenrick
Copy link
Owner

PR #125 made use of aria-label and aria-roledescription in multiple places in main.hbs to make the homepage more accessible. However the values of these attributes are currently hard coded strings. They should be translated to support languages other than English and make use of the Handlebars templating for rendering text.

There is also image alt text for the rent history modal overlay that needs to be translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant