Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiber demo does not increment the number inside the circles #3

Open
miguel550 opened this issue Sep 29, 2017 · 5 comments
Open

Fiber demo does not increment the number inside the circles #3

miguel550 opened this issue Sep 29, 2017 · 5 comments

Comments

@miguel550
Copy link

The number inside the circles is fixed to 0. It should increment just like the Stack version demo.

@claudiopro
Copy link
Owner

Hi @miguel550 thanks for reporting this. Do you see this by installing latest dependencies? I can't repro on the github hosted app https://claudiopro.github.io/react-fiber-vs-stack-demo/

@miguel550
Copy link
Author

It's happening to the Fiber version in Chrome Version 61.0.3163.100 (Official Build) (64-bit) for Windows 10 using the github hosted app. In Microsoft Edge seems to work.

@Denhai
Copy link

Denhai commented Jan 3, 2018

Hmm, numbers increment on Safari 11.0.2 but not Chrome

@jsobell
Copy link

jsobell commented Mar 18, 2018

Same issue with Firefox

@ryansolid
Copy link

ryansolid commented Feb 12, 2019

I was able to reproduce this quite easily by CPU throttling in chrome. On my computer it works properly incrementing the numbers until I apply CPU throttling. I think Fiber is just optimizing out the number incrementing in some scenarios. I did a similar test of Stencils version of the test and I saw a form of tearing where some numbers updated separately from others. In another example from a different framework under cpu throttling I saw the numbers update but it visibly stall like the stack version, even though it was as fast as fiber in normal operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants