Add hostport to use qrcp in local server with reverse proxy #184

mattn · 2020-11-04T03:30:48Z

Added hostport option to display really acceptable host:port via reverse proxy.

Fixes #169

If you think that FQDN is that and hostport should be passed to listen instead, please let me known.

claudiodangelis · 2020-11-26T09:34:00Z

Hello @mattn, thanks for this contribution. I didn't have time to review it yet, will hopefully do over the weekend.

Thanks,
C

claudiodangelis · 2021-01-19T17:18:52Z

I'm not too much convinced about the name of the flag.
Considering the following cases, I would rather go with something like --baseurl:

Case	Args	Printed URL
no reverse proxy	`-i tun0 -p 8080`	http://10.8.0.1:8080/send/A1s3
no reverse proxy tls certs	`--tls-(cert,key...) -i tun0 -p 8080`	https://10.8.0.1:8080/send/A1s3
reverse proxy target is localhost:8080	`--baseurl http://example.com -i lo -p 8080`	http://example.com/send/A1s3
reverse proxy target is localhost:8080 target on custom location	`--baseurl http://example.com/qrcp -i lo -p 8080`	http://example.com/qrcp/send/A1s3
reverse proxy reverse proxy port 3000 target is localhost:8080	`--baseurl http://example.com:3000 -i lo -p 8080`	http://example.com:3000/send/A1s3

Basically, if baseurl is passed, other parameters that control the printed URL (i.e.: --secure) should be ignored.
What do you think?

claudiodangelis · 2022-03-11T18:36:14Z

I will close this for now.

Add hostport to use qrcp in local server with reverse proxy

5751517

claudiodangelis closed this Mar 11, 2022

Provide feedback