Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate AWS SDK for JavaScript v2 APIs to v3 #244

Closed
wants to merge 9 commits into from
Closed

Migrate AWS SDK for JavaScript v2 APIs to v3 #244

wants to merge 9 commits into from

Conversation

trivikr
Copy link

@trivikr trivikr commented Nov 2, 2023

Fixes: #243

@trivikr trivikr changed the title chore: run aws-sdk-js-codemod@0.26.1 on src/**/*.js Migrate AWS SDK for JavaScript v2 APIs to v3 Nov 2, 2023
@trivikr
Copy link
Author

trivikr commented Nov 2, 2023

Discontinued as AWS SDK for JavaScript v2 is passed in postDeploy command to apiModule

claudia/src/commands/create.js

Lines 252 to 265 in 9d68ed4

return apiModule.postDeploy(
options,
{
name: lambdaMetadata.FunctionName,
alias: alias,
apiId: lambdaMetadata.api.id,
apiUrl: lambdaMetadata.api.url,
region: options.region
},
{
apiGatewayPromise: apiGatewayPromise,
aws: aws
}
);

Moving this to v3 will require input from maintainers

@trivikr trivikr closed this Nov 2, 2023
@trivikr trivikr deleted the aws-sdk-js-codemod branch November 2, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate AWS SDK for JavaScript v2 APIs to v3
1 participant
@trivikr