New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mistake For "React.FC" #855

Open

tarnishablec opened this issue Sep 15, 2022 · 1 comment

tarnishablec commented Sep 15, 2022 •

edited

react-sortable-hoc/types/index.d.ts

Line 108 in caf3c4f

| React.SFC<P>

React.SFC is now deprecated

ronparkdev commented Sep 28, 2022

Yes, It should modify to | React.FC<P>

    /**
     * @deprecated as of recent React versions, function components can no
     * longer be considered 'stateless'. Please use `FunctionComponent` instead.
     *
     * @see [React Hooks](https://reactjs.org/docs/hooks-intro.html)
     */
    type SFC<P = {}> = FunctionComponent<P>;

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/a51e3613b44c4ae400d040592bb4f56fd3fa8a4f/types/react/index.d.ts#L528-L534

ronparkdev mentioned this issue

fix: change deprecated React.SFC to React.FC #857

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment