(fix) call onSelect with interpolated data #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinNuc
force-pushed
the
interpolated-changes
branch
2 times, most recently
from
e230846
to
9ad3d87
Compare
MartinNuc
force-pushed
the
interpolated-changes
branch
from
9ad3d87
to
0491eb0
Compare
MartinNuc
changed the title
Cardosoli
approved these changes
Aug 12, 2019
|
Is it possible to merge? Otherwise I will close this PR as it has been here for one year already. |
|
I am closing this PR. Apparently this open source project is dead ☠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #221
I am trying to use this library with multi selection on.
Problem is that
onSelectis called with a single value not the whole array. The reason is because interpolate function is used to update internal state but not for callingonSelect.I believe this should fix the issue but I am new to this library so I would like to ask for a deeper code review. Thank you.