Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs duplicate some months, miss others #140

Open
dimitropoulos opened this issue Sep 12, 2017 · 11 comments · May be fixed by #150
Open

docs duplicate some months, miss others #140

dimitropoulos opened this issue Sep 12, 2017 · 11 comments · May be fixed by #150

Comments

@dimitropoulos
Copy link

image

http://clauderic.github.io/react-infinite-calendar/#/customization/select-year-first?_k=0pth0m

@dimitropoulos dimitropoulos changed the title docs list March twice, miss Feb docs duplicate some months, miss others Sep 12, 2017
@clauderic
Copy link
Owner

What browser are you using / which timezone are you in?

@michaelolo24
Copy link

I'm getting the same error in the US (east coast)

@dimitropoulos
Copy link
Author

chrome in ET

@talibasya
Copy link

talibasya commented Oct 13, 2017

I had the same when selected was moment.toString() value.
Helped replacing by native js Date object 😎

EDIT: no. It didn't help 😞

@layerssss
Copy link

Same problem in Chrome 62 OSX, NZDT (+1300), the component was initialised with selected (regardless of being an ISOString or a Date) and display="years" and onSelect, width, height.

image
image
image

@meta-meta
Copy link

meta-meta commented Oct 31, 2017

I believe this is the issue https://github.com/clauderic/react-infinite-calendar/blob/master/src/Years/index.js#L53

and https://github.com/clauderic/react-infinite-calendar/blob/master/src/utils/index.js#L160
If the selected date is out of range for the month, the next month is returned.

meta-meta added a commit to meta-meta/react-infinite-calendar that referenced this issue Oct 31, 2017
meta-meta added a commit to meta-meta/react-infinite-calendar that referenced this issue Oct 31, 2017
mvayngrib pushed a commit to tradle/react-infinite-calendar that referenced this issue Apr 9, 2018
@leron8
Copy link

leron8 commented Jun 26, 2018

Hey we're also having this issue! I see that @mvayngrib committed a fix. Does that solve it.? It hasn't been merged for a release right?

@meta-meta
Copy link

@leron8 I've had a PR open for 8 months. #150
It fixes the issue.

@leron8
Copy link

leron8 commented Jun 26, 2018

Thanks @meta-meta , how could I use that fix? would I have to fork this repo and build it myself or is the only option to wait for the pull request to be merged?

@meta-meta
Copy link

@leron8 Yes, I believe that's the only thing you can do until it's merged and published. If you want, feel free to use my fork by adding this to your package.json: "react-infinite-calendar": "meta-meta/react-infinite-calendar#built",

@leron8
Copy link

leron8 commented Jun 26, 2018

great @meta-meta I see that it's the only change you comparing to the original repo right? master...meta-meta:master ... well besides this: d32f20c but it only changes README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants