Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytecode compiler doesn't establish a compilation unit #1431

Open
Bike opened this issue Feb 23, 2023 · 0 comments
Open

bytecode compiler doesn't establish a compilation unit #1431

Bike opened this issue Feb 23, 2023 · 0 comments
Labels
bug compiler

Comments

@Bike
Copy link
Member

Bike commented Feb 23, 2023 •
edited

This mostly doesn't matter since it doesn't signal warnings - though that's a problem in itself. However, it does not bind the function refs and defs tables. This means that if it calls out to Cleavir, as it does for saving inline definitions, and hits an undefined function, you get an unhelpful error.

(declaim (inline foo))
(cmp:bytecompile '(lambda () (defun foo () (bar))))
; => The variable COMPILER::*GLOBAL-FUNCTION-REFS* is unbound.
Bike added a commit that referenced this issue Jun 16, 2023
@Bike
bytecode compiler: warn on unknown function
51d4ac1 
Also set things up so that more general bytecode compiler
conditions can get accurate source info.

For now this only works during compile-file, because compile/eval
doesn't set up a compilation unit. The conditionalization does
also fix the particular problem in #1431.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bike