Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureLibrary: Only create empty GOL if a tileset URL is specified #87

Open
tordanik opened this issue Mar 6, 2023 · 1 comment
Open

FeatureLibrary: Only create empty GOL if a tileset URL is specified #87

tordanik opened this issue Mar 6, 2023 · 1 comment
Labels
todo A feature that has been specified, but not yet implemented

Comments

@tordanik
Copy link

tordanik commented Mar 6, 2023

I've had a .gol file created when I attempted to read a non-existing file. This is undocumented for this particular constructor, and at least for me it was surprising behavior.
@clarisma clarisma mentioned this issue Mar 16, 2023
Open
@clarisma clarisma changed the title FeatureLibrary constructor creates .gol file if it does not exist FeatureLibrary: Only create empty GOL if a tileset URL is specified Mar 16, 2023
@clarisma clarisma added the todo A feature that has been specified, but not yet implemented label Mar 16, 2023
@clarisma
Copy link
Owner

Good point, thanks!

Unless the caller supplies a tileset URL from which tiles can be fetched, creating an empty GOL makes no sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo A feature that has been specified, but not yet implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tordanik @clarisma