Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Update preTransactionFileSize after each call to commit() #68

Open
clarisma opened this issue Nov 28, 2022 · 0 comments
Open

Store: Update preTransactionFileSize after each call to commit() #68

clarisma opened this issue Nov 28, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@clarisma
Copy link
Owner

If there is more than one commit in a transaction, blocks appended beyond preTransactionFileSize during a previous commit phase are not journaled; if a later phase in the same transaction modifies these blocks, but fails before completing commit(), partial modifications may not be rolled back.

Solution: Rename preTransactionFileSize to preCommitFileSize, and update after each call to commit().

@clarisma clarisma added the bug Something isn't working label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant