Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables for --config and --apikey #183

Closed
wants to merge 3 commits into from

Conversation

jqnatividad
Copy link
Contributor

@jqnatividad jqnatividad commented Jan 28, 2021

Resolves #179.

Added --apikey as well. Not only is it convenient at the CLI, its also good for securely passing secrets when containerizing.

for --config and --apikey
ckanapi/cli/main.py Outdated Show resolved Hide resolved
Co-authored-by: Ian Ward <ian@excess.org>
@wardi
Copy link
Contributor

wardi commented Apr 27, 2021

for -c it looks like this change isn't necessary, we launch the ckan cli or paster and they take care of loading the default configuration.

I don't love CKANAPI_KEY as a config option without also having a remote url specified. It could lead to accidentally disclosing your API key to the wrong CKAN site when you pass a -r parameter.

@jqnatividad
Copy link
Contributor Author

Closing obsolete PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Use CKAN_INI env variable like CKAN cli command
2 participants