Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Protections for Fish Bucket Placement #205

Open
cjburkey01 opened this issue Jul 28, 2021 · 2 comments
Open

Missing Protections for Fish Bucket Placement #205

cjburkey01 opened this issue Jul 28, 2021 · 2 comments
Assignees
@cjburkey01
Labels
bug Unintended behavior that has some effect on gameplay
Milestone
0.0.24

Comments

@cjburkey01
Copy link
Owner

Check for new spigot events to listen to
@cjburkey01 cjburkey01 self-assigned this Jul 28, 2021
@cjburkey01 cjburkey01 added the bug Unintended behavior that has some effect on gameplay label Jul 28, 2021
@cjburkey01 cjburkey01 added this to the 0.0.23 milestone Jul 28, 2021
@Goldmensch
Copy link
Contributor

I think this can be handled by the PlayerInteractEvent

@cjburkey01
Copy link
Owner Author

cjburkey01 commented Aug 8, 2021 •
edited

I think this can be handled by the PlayerInteractEvent

Do you know how to implement this? I added a handler for PlayerBucketEntityEvent in b7201d3 but if this is handled by the PlayerInteractEvent, shouldn't it be handled by this handler?

I'm going to have a better look at this mess of a function. I don't want to have to handle by making sure it's a fish bucket because I feel like that would lead to a bunch of compatibility problems if they ever change, especially across versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjburkey01 cjburkey01

Labels
bug Unintended behavior that has some effect on gameplay
Projects
None yet
Milestone
0.0.24
Development

No branches or pull requests
2 participants
@cjburkey01 @Goldmensch