Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature where you can add more chunk claims to the max chunks #158

Open
WizWazWizard opened this issue Aug 24, 2020 · 7 comments
Open
Assignees
Labels
enhancement Suggested change to the plugin

Comments

@WizWazWizard
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I want to give someone 1 extra chunk when they vote, this will add to their max chunks. So if someone has a max of 16 chunks they can naturally claim, they can vote and it will +1 Max Chunks, making it 17 max
Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mapacheee
Copy link

inside the config.yml you can edit the maximum chunk claim

@WizWazWizard
Copy link
Author

This can't be automatically edited however

@mapacheee
Copy link

you have to edit it and then restart the server, the claimchunk reload does not work

@cjburkey01
Copy link
Owner

Oh the reload doesn't work? (It's been a while but, if you're willing, could you create a separate report for reload not working?)

@cjburkey01
Copy link
Owner

I actually have been considering a max chunk claim override for a little while now but I haven't fully decided on the implementation. I'm thinking that it can be a separate value stored with the player's data and it takes precedence over all other chunk claim defaults. In theory, the way it would work is the default in the config is used as the max unless the player has a rank; if they do have a rank, that value is used–whether smaller or larger. This new system would basically say that if the player has any override maximum value, then the player will be allowed to claim that many chunks, no matter what either of those other options apply. Does that sound like a fair solution?

@cjburkey01 cjburkey01 added the enhancement Suggested change to the plugin label Sep 26, 2020
@cjburkey01 cjburkey01 self-assigned this Sep 26, 2020
@WizWazWizard
Copy link
Author

Yep :)

@JustDoom
Copy link
Contributor

I think you could just save an int in the players data that says how many extra chunks they can have and it adds onto whatever the players default max claims is, whether its from a rank or from the config.yml. You could also use this to decrease the max claims of players.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggested change to the plugin
Projects
None yet
Development

No branches or pull requests

4 participants