Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DORAs should be treated the same as LORAs for keeping the filename #1163

Open
lendrick opened this issue May 7, 2024 · 0 comments
Open
Labels
bug-report Something might not be working

Comments

@lendrick
Copy link

lendrick commented May 7, 2024

What happened?

DORA filenames get mangled as if they're checkpoints.

Steps to reproduce the problem

Upload a DORA. Click the download button. Note that the filename has changed.

What should have happened?

DORAs should be treated like LORAs and the filename should be untouched.

What platforms do you use to access the site?

Windows, Android

What browsers do you use to access the site?

Mozilla Firefox

Additional information, context and logs

Looks like this line is where it needs to be fixed:

const shouldKeepFilename =

@lendrick lendrick added the bug-report Something might not be working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Something might not be working
Projects
None yet
Development

No branches or pull requests

1 participant