Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: undocumented API query param for base model filtering #1035

Open
AntitrustEnthusiast opened this issue Feb 29, 2024 · 2 comments
Open
Labels
bug-report Something might not be working

Comments

@AntitrustEnthusiast
Copy link

AntitrustEnthusiast commented Feb 29, 2024

What happened?

Edit: this issue was previously to add the param, but it seems to already exist as an undocumented param. Changed this issue to a documentation request instead.

this query param actually is available, under baseModels=.

Request has been modified to document this param under API reference

Steps to reproduce the problem

  1. Go to this page: https://github.com/civitai/civitai/wiki/REST-API-Reference#get-apiv1models
  2. baseModels param is not documented

What should have happened?

API reference should have baseModels param documented

What platforms do you use to access the site?

Windows, Other/Cloud

What browsers do you use to access the site?

Mozilla Firefox

Additional information, context and logs

No response

@AntitrustEnthusiast AntitrustEnthusiast added the bug-report Something might not be working label Feb 29, 2024
@tadams0
Copy link

tadams0 commented Mar 6, 2024

I believe the query param for that is "baseModels" with an s. I'm not sure where this is documented though.

@AntitrustEnthusiast AntitrustEnthusiast changed the title [Bug]: API does not allow filtering by base model [Bug]: undocumented API query param for base model filtering Mar 6, 2024
@AntitrustEnthusiast
Copy link
Author

Oh wow, yeah that works exactly as expected. Thanks a ton!

Changing issue to documentation request, since it just needs to be added to this page:

https://github.com/civitai/civitai/wiki/REST-API-Reference#get-apiv1models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Something might not be working
Projects
None yet
Development

No branches or pull requests

2 participants