Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Editor's currentMode handling #100

Open
BrunoSalerno opened this issue Dec 3, 2017 · 0 comments
Open

Improve Editor's currentMode handling #100

BrunoSalerno opened this issue Dec 3, 2017 · 0 comments

Comments

@BrunoSalerno
Copy link
Member

BrunoSalerno commented Dec 3, 2017 •
edited

The listener => store => prop circuit may not be fine. Also, some modes, such as direct_select, require also options, that don't come from the draw.changemode event and that are not being set through props (there is only the currentMode prop, that is a String)
@BrunoSalerno BrunoSalerno changed the title Improve Editor's customMode handling Improve Editor's currentMode handling Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BrunoSalerno