Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into adding permissions to the example workflow #67

Open
jspaaks opened this issue Feb 8, 2022 · 2 comments
Open

Look into adding permissions to the example workflow #67

jspaaks opened this issue Feb 8, 2022 · 2 comments

Comments

@jspaaks
Copy link
Member

jspaaks commented Feb 8, 2022

Spawned by discussion in JuliaLang/julia. Thanks @DilumAluthge for the suggestion.

@kevinmatthes
Copy link

I would like to add that furthermore also pinning the version of an Action to a release commit might have benefits. If you take a look at the GitHub Action of cffreference which is the subject of citation-file-format/citation-file-format#384, you will find a working example which implements both pinning the Action versions to a release commit as well as the minimum permissions to ensure the correctness.

Since the default permission set GitHub grants the session token for an Action does not always fit the Action's intention, at least in my opinion adding the minimum permissions in both the example as well as the corresponding applications of the Action in this namespace would be a meaningful change.

To see the permissions granted by default, just go to the "Actions" tab of a project of your choice which applies them, choose an arbitrary Action which was completed not too long ago, expand "Set up job", and, in there, "GITHUB_TOKEN Permissions". Try to find an Action which does not explicitly limit the granted permissions.

@kevinmatthes
Copy link

I submitted a Pull Request related to this topic to the main project. citation-file-format/citation-file-format#406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants