Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a text for outreach #60

Open
jspaaks opened this issue Jan 24, 2022 · 9 comments
Open

Write a text for outreach #60

jspaaks opened this issue Jan 24, 2022 · 9 comments

Comments

@jspaaks
Copy link
Member

jspaaks commented Jan 24, 2022

Now that we have released version 2.0.0, we could reach out to some folks on GitHub to add the "cffconvert --validate" workflow to their repos via a Pull Request. It's probably a good start to limit this outreach to repos:

  1. that already use CITATION.cff files
  2. that have other workflows on GitHub Actions
  3. that still see some development, preferably with multiple contributors
  4. that work with Pull Requests
  5. that do not already use a different validator
  6. that did not previously receive a similar Pull Request from us
  7. (during testing) that occur in the list of repos from research-software.nl/api/software
  8. (during testing) LIMIT 20

Once we have a draft text for a Pull Request that adds cffconvert, I suggest we try it out on our colleagues first. If we're happy with their feedback, we can use GitHub search to find other repos that qualify according to the bullet points above, and send them a PR as well.

@jspaaks
Copy link
Member Author

jspaaks commented Jan 25, 2022

If we decide to automate some of the above steps, I suggest we use a library to query github, e.g. using any of these https://docs.github.com/en/rest/overview/libraries

@abelsiqueira
Copy link
Collaborator

We could try looking for people who have updated or fixed their CITATION.cff file.

@jspaaks
Copy link
Member Author

jspaaks commented Jan 25, 2022

I suggest splitting the "filtering" (basically the steps above) from the "sending a PR" part. Basically the filtering should result in a curated list of repos.

@fdiblen
Copy link
Collaborator

fdiblen commented Jan 25, 2022

We (@jspaaks, @abelsiqueira, @fdiblen), decided to remove item 3 and add

  • Check if they accept PRs from external contributors
  • Check and follow CONTRIBUTIN..md if that exists
  • Check if CITATION.cff file was updated before

@fdiblen
Copy link
Collaborator

fdiblen commented Jan 25, 2022

The final list for

filtering:

  1. that already use CITATION.cff files
  2. that have other workflows on GitHub Actions
  3. that work with Pull Requests
  4. that do not already use a different validator
  5. that did not previously receive a similar Pull Request from us
  6. Check if they accept PRs from external contributors
  7. Check and follow CONTRIBUTIN.md if that exists
  8. Check if CITATION.cff file was updated before

sorting:

  1. (during testing) that occur in the list of repos from research-software.nl/api/software
  2. (during testing) LIMIT 30

@fdiblen
Copy link
Collaborator

fdiblen commented Jan 25, 2022

We, GT, will first create an issue and ask developers whether they want us to create a PR. Based on the feedback we will create a PR.
For the interaction we will use @nlescgt account.

@jspaaks
Copy link
Member Author

jspaaks commented Jan 25, 2022

Found another thing to think about: nesting levels, e.g. https://github.com/unwitting-life/cpp-Qt/blob/573f035036485ebb72d6de977ba5bc51d4270385/lib/impl/nlohmann/json/CITATION.cff looks like a checked-in dependency, i.e. not the repo owner's job to correct.

@jspaaks
Copy link
Member Author

jspaaks commented Jan 26, 2022

What do we do with repos where the CITATION.cff file does not pass validation?

@fdiblen
Copy link
Collaborator

fdiblen commented Jan 26, 2022

We will do the outreach work here: https://github.com/cffbots/filtering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants