Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Citing Obsolete SPF RFC 4408 vice Current RFC 7208 #136

Open
chrislandis opened this issue Jun 10, 2023 · 1 comment · May be fixed by #137
Open

Citing Obsolete SPF RFC 4408 vice Current RFC 7208 #136

chrislandis opened this issue Jun 10, 2023 · 1 comment · May be fixed by #137
Labels
documentation This issue or pull request improves or adds to documentation

Comments

@chrislandis
Copy link

I noticed in the documentation that it cites RFC 4408, which RFC 7208 has superseded.

trustymail/README.md

Lines 141 to 142 in 585c9a8

- `Valid SPF` - Whether the SPF record found is syntactically correct,
per RFC 4408.

I cannot find anywhere else in the project that cites RFC 4408, but RFC 7208 is cited in #7 (comment) and #21 (comment). Comparing the trustymail code and these two RFCs, it seems that trustymail does not conflict with RFC 7208 and should cite it instead of RFC 4408.

If you would like, I can make this one-line change in the README and submit a pull request.
@jsf9k jsf9k assigned jsf9k and unassigned jsf9k Jun 12, 2023
@jsf9k jsf9k added the documentation This issue or pull request improves or adds to documentation label Jun 12, 2023
@jsf9k
Copy link
Member

jsf9k commented Jun 12, 2023

Thank you for the issue, @chrislandis!

Please feel free to go ahead and make the change to the README. While you're at it, we may as well make the RFC 7208 text link to the RFC as well.

@chrislandis chrislandis linked a pull request Jun 12, 2023 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation This issue or pull request improves or adds to documentation
Projects
CyHy System
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated RFC 4408 citation to RFC 7208 and added link in README chrislandis/trustymail
2 participants
@jsf9k @chrislandis