Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hotfix for vinyl-fs failure after node releases a fix #2093

Open
2 tasks
zandercymatics opened this issue Apr 29, 2024 · 0 comments · May be fixed by #2212
Open
2 tasks

Revert hotfix for vinyl-fs failure after node releases a fix #2093

zandercymatics opened this issue Apr 29, 2024 · 0 comments · May be fixed by #2212

Comments

@zandercymatics
Copy link
Contributor

zandercymatics commented Apr 29, 2024

Current Behavior

Our deploy-sandbox.yaml, deploy-stable.yaml, deploy-staging.yaml, deploy-development.yaml, and node.Dockerfile files are using less than ideal code due to a necessary hotfix. These should be reverted to how they were before.

Expected Behavior

  1. The changes for this PR are reverted
  2. Our deploy works correctly, and gulp "copyAsset" compiles without any errors.

Steps to Reproduce

  1. On your chosen environment, revert back to this commit and compare the content difference for these files: deploy-sandbox.yaml, deploy-stable.yaml, deploy-staging.yaml, and deploy-development.yaml, and node.Dockerfile

Environment

All environments

Additional Context

PR #2090 addresses a bug wherein node version 22 breaks vinyl-fs and gulp. While a PR on their repo was merged that addresses this change, it could take 1-3 weeks for that to land in the next node version. The workaround for now is to revert our node version back to 21.7.3. This workaround is less than ideal, so we should revert back to the old way of doing things once this lands.

Issue Links

Relates to: #2090
Related to: #2085

@zandercymatics zandercymatics added bug Something that isn't working as intended dev refactor quick fix and removed bug Something that isn't working as intended labels Apr 29, 2024
@zandercymatics zandercymatics changed the title Reminder: Revert hotfix for vinyl-fs failure after node releases a fix Revert hotfix for vinyl-fs failure after node releases a fix Apr 29, 2024
@zandercymatics zandercymatics self-assigned this May 23, 2024
@zandercymatics zandercymatics linked a pull request May 23, 2024 that will close this issue
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

1 participant