-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A circe-spire module? #1051
Comments
Sounds good to me! I think I'd prefer a new circe org repo rather than a module here, since e.g. Spire doesn't have 2.13.0-Mx artifacts yet, etc. |
Cool! What's the best way to get started on that? You create the repo and I'll make a PR? :) |
Yep, just sent an invite: https://github.com/circe/circe-spire |
I'd recommend using something like circe-bson as a template (and adding the repo to scala-steward's list) to keep some kind of consistency, but definitely not required: https://github.com/circe/circe-bson |
Done! circe/circe-spire@a6b334b @travisbrown if you'd go for a quick review I'd be grateful :) |
Looks good to me (I noticed one mention of circe-bson left over in the |
P.S. Travis CI is now working, and I opened circe/circe-spire#2. |
It'd be nice to be able encode and decode spire numeric types like
SafeLong
,Rational
,UInt
orAlgebraic
. I have implemented some of them in a recent project and could contribute them if wanted :)The text was updated successfully, but these errors were encountered: