Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A circe-spire module? #1051

Closed
LukaJCB opened this issue Jan 8, 2019 · 7 comments
Closed

A circe-spire module? #1051

LukaJCB opened this issue Jan 8, 2019 · 7 comments

Comments

@LukaJCB
Copy link
Contributor

LukaJCB commented Jan 8, 2019

It'd be nice to be able encode and decode spire numeric types like SafeLong, Rational, UInt or Algebraic. I have implemented some of them in a recent project and could contribute them if wanted :)

@travisbrown
Copy link
Member

Sounds good to me! I think I'd prefer a new circe org repo rather than a module here, since e.g. Spire doesn't have 2.13.0-Mx artifacts yet, etc.

@LukaJCB
Copy link
Contributor Author

LukaJCB commented Jan 8, 2019

Cool! What's the best way to get started on that? You create the repo and I'll make a PR? :)

@travisbrown
Copy link
Member

Yep, just sent an invite: https://github.com/circe/circe-spire

@travisbrown
Copy link
Member

I'd recommend using something like circe-bson as a template (and adding the repo to scala-steward's list) to keep some kind of consistency, but definitely not required: https://github.com/circe/circe-bson

@LukaJCB
Copy link
Contributor Author

LukaJCB commented Jan 8, 2019

Done! circe/circe-spire@a6b334b

@travisbrown if you'd go for a quick review I'd be grateful :)

@travisbrown
Copy link
Member

Looks good to me (I noticed one mention of circe-bson left over in the build.sbt, but can open a PR for it later). I also just tried to enable Travis CI and it's telling me "You don't have sufficient rights to enable this repo on Travis. Please contact the admin to enable it or to receive admin rights yourself."—even though I created the repo myself. I'll try to get that worked out now.

@travisbrown
Copy link
Member

P.S. Travis CI is now working, and I opened circe/circe-spire#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants