Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang for libpcap and CGO compilation #221

Open
brb opened this issue Jul 6, 2023 · 5 comments
Open

Use clang for libpcap and CGO compilation #221

brb opened this issue Jul 6, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@brb
Copy link
Member

brb commented Jul 6, 2023

For the BPF code compilation we already use clang. Let's use the same compiler for the libpcap.a and CGO compilations.

@brb brb added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 6, 2023
@swastik959
Copy link

swastik959 commented Jul 9, 2023

@brb hi I want to work on this issue can you guide me through it

@brb
Copy link
Member Author

brb commented Jul 10, 2023

@swastik959 Hi, thanks for taking it. A C compiler is used in the following places:

The issue is about using Clang for those in https://github.com/cilium/pwru/tree/main/.github/workflows.

@swastik959
Copy link

@brb do I only need to change the CC and LIBPCAP_CC to clang

@brb
Copy link
Member Author

brb commented Jul 10, 2023

Most likely yes - in the GH workflows.

@brb
Copy link
Member Author

brb commented Jul 31, 2023

👋 @swastik959 Any update on the issue?

@brb brb assigned brb and unassigned swastik959 Aug 2, 2023
@brb brb removed their assignment Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants