Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: report file/line information for drop notifications #1216

Open
julianwiedmann opened this issue Sep 11, 2023 · 4 comments
Open
Labels
👍 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. 🙏 help-wanted Please volunteer for this by adding yourself as an assignee! kind/enhancement This would improve or streamline existing functionality.

Comments

@julianwiedmann
Copy link
Member

cilium/cilium#20387 introduced source file/line information for drop notifications. The PR also added cilium monitor support.

It would be great to also surface this error information in hubble.

@julianwiedmann julianwiedmann added the kind/enhancement This would improve or streamline existing functionality. label Sep 11, 2023
@brb brb added the 🙏 help-wanted Please volunteer for this by adding yourself as an assignee! label Nov 17, 2023
@michi-covalent michi-covalent added the 👍 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. label Nov 17, 2023
@sadath-12
Copy link

assign me please

@Gnoale
Copy link

Gnoale commented Apr 23, 2024

Hello, can you point me in the right direction / elaborate about this one ? I'd like to contribute

@Gnoale
Copy link

Gnoale commented Apr 23, 2024

Something seems off in the vendor folder : it is missing a lot of files from pkg/monitor/ although the tag that is vendor into this repository has all these files, among them datapath_drop.go which hold the DropNotify struct

✔ ~/git/cilium [v1.15.3|✔] 
11:47 $ ls pkg/monitor/
agent              datapath_debug_test.go  datapath_policy_test.go      datapath_trace.go       format         types.go
alignchecker       datapath_drop.go        datapath_recorder.go         datapath_trace_test.go  logrecord.go
api                datapath_drop_test.go   datapath_sock_trace.go       dissect.go              notifications
datapath_debug.go  datapath_policy.go      datapath_sock_trace_test.go  dissect_test.go         payload

My guess is hubble should somehow build this object and so get access to the DumpInfo function to print all the information mentioned

@glibsm
Copy link
Member

glibsm commented Apr 23, 2024

@sadath-12 are you still interested in working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. 🙏 help-wanted Please volunteer for this by adding yourself as an assignee! kind/enhancement This would improve or streamline existing functionality.
Projects
Status: No status
Development

No branches or pull requests

6 participants