Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set *read-default-float-format* to 'double-float #32

Open
bo-tato opened this issue May 23, 2023 · 5 comments
Open

set *read-default-float-format* to 'double-float #32

bo-tato opened this issue May 23, 2023 · 5 comments

Comments

@bo-tato
Copy link

bo-tato commented May 23, 2023

I'm too new at lisp to be suggesting such changes, but I was reading common lisp recipes and Edi Weitz suggests setting this in .sbclrc. It seems like a sensible default, maybe it makes sense for ciel to set this by default?

@vindarel
Copy link
Contributor

+ 1 I was hit by single floats already.

Let's not rush and be sure there would not be surprising side-effects, maybe especially in popular third-party libraries. Being a suggestion in CL Recipes gives it a lot of weight though!

thanks

@bo-tato
Copy link
Author

bo-tato commented Jun 2, 2023

sounds good, I've got it set in my .sbclrc and will report if I run into any issue with it

@bo-tato
Copy link
Author

bo-tato commented Aug 17, 2023

well it caused the first issue, I was building ciel again from scratch and got an error when it builds nodgui:

[package nodgui-user].......While evaluating the form starting at line 12, column 0
  of #P"/home/user/quicklisp/local-projects/CIEL/build-image.lisp":

debugger invoked on a TYPE-ERROR @53069491 in thread
#<THREAD tid=4405 "main thread" RUNNING {10013B8113}>:
  The value
    0.0d0
  is not of type
    SINGLE-FLOAT
  when binding SB-C::ITEM

Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.

@bo-tato
Copy link
Author

bo-tato commented Jan 26, 2024

A fix is merged into nodgui and now CIEL builds and seems to work fine with (setf *read-default-float-format* 'double-float)

@vindarel
Copy link
Contributor

Thanks! I'll try it a bit in my day-to-day and all projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants