Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting started guide #761

Open
dataf3l opened this issue May 8, 2024 · 1 comment
Open

getting started guide #761

dataf3l opened this issue May 8, 2024 · 1 comment
Assignees

Comments

@dataf3l
Copy link

dataf3l commented May 8, 2024

in the guide you say:

https://github.com/chromaui/learnstorybook.com/blob/master/content/intro-to-storybook/react/en/get-started.md

git add .

this may accidentally add the node_modules folder.

should we add a step to prevent that? maybe some new person will make this mistake and will create large repos.

just a thought

@jonniebigodes
Copy link
Collaborator

@dataf3l thanks for reaching out to us with your feedback. We appreciate it. While I understand your reasoning, both the template and a standard application initialized via a generator (e.g., Vite) will automatically set up a .gitignore file configured with a set of files and directories that should not be committed and pushed to a repository. Adding it wouldn't bring anything new to the tutorial and would add a breaking point in the documentation (if it was added as an aside), or extend it more unnecessarily.

@jonniebigodes jonniebigodes self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants