Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum price styling issue when currency has more than one character #10

Open
christophermallory opened this issue Sep 17, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@christophermallory
Copy link
Owner

Hi,

There is an error with other currencies. For example, with the CHF currency https://prnt.sc/nUja5DESsgOU

If the currencies have more than 1 character, there will be a problem.

Originally posted by @swissbull in #9 (comment)

@christophermallory
Copy link
Owner Author

Before merging this into the repo as a tagged release, I am looking for testers. Please comment and screenshot your results.

@FadedOut
Copy link

@swissbull
It's not the perfect fix, nor is it probably the best solution but temporarily (until the dev can fix it properly) you could modify by CSS changes. Using a custom css file (or if your theme has the option to input custom CSS) enter the following:

.cart-summary .freeship-progress .freeship-progress-bar-wrapper .freeship-progress-bar-bg {
width: 85%;
margin-left: 23px;
}

By including the .cart-summary css selector it shouldn't affect any other place on the site (like the product page) - unless you want it to be changed there as well, simply remove the .cart-summary css selector and it should be changed there too.

It will now look like this on each device viewpoint:

Desktop:
free-shipping-bar-desktop-view

Tablet:
free-shipping-bar-tablet-view

Mobile:
free-shipping-bar-mobile-view

If you know CSS a little bit you could create flexible viewpoints using the @media rule like @media only screen and (max-width: 768px) then @media only screen and (max-width: 1024px) and modify the css code I used above (the width only) to fit the screen sizes better. More info about that here: W3Schools.com

@christophermallory Hey sorry I would test but I currently don't have a staging site set up and I am also using USD which works fine for that currency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants