Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing renders on Android with RN 0.50.3 #177

Open
mattias800 opened this issue Nov 29, 2017 · 0 comments
Open

Nothing renders on Android with RN 0.50.3 #177

mattias800 opened this issue Nov 29, 2017 · 0 comments

Comments

@mattias800
Copy link

This issue description might be a bit vague, but in our app, the calendar disappeared (shows nothing) on Android after upgrading both to RN 0.50.3 and react-native-calendar to 0.13.1.

After some investigation, we think that this code causes the error:

    if (this.state.containerWidth == null) {
        return <View onLayout={this.onContainerLayout} style={containerStyle} />;
    }

The theory is that onContainerLayout doesn't get width and height, or doesn't run at all. We haven't verified this though, hence vague :)

We set width and height on containerStyle and suddenly the calendar appears.

This was not a problem with RN 0.44.2 and react-native-calendar@0.10.0 on Android. We were unable to test versions between 0.10.0 and the latest, since only the latest imports prop-types from its own package, instead of from the 'react' package.
We haven't tested it with other versions of RN either, because time :)

Sorry about not writing an awesome issue, but I thought it was better to report it like this, rather than not at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant