Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_abort #410

Closed
OliveiraICTS opened this issue Dec 27, 2023 · 2 comments
Closed

test_abort #410

OliveiraICTS opened this issue Dec 27, 2023 · 2 comments

Comments

@OliveiraICTS
Copy link

Hello,

I´m studing CANopen protocols and I found your excellent Source code in Python on github.
Now I´m studying SDO session and matching with your code and everyghing looks okay, except one.
on test_sdo.py the function test_abort you are sending a the same message to the same endpoint index 1018 subindex 01 used on test expedicted_upload. It is included on sample.eds file used as reference.

Question: You are raising the exception code 0x06090011 just for test?

The reason is that 0x1018 0x01 is a mandatory and the above exception code is rased if its subindex not found on dictionary. Is it right?

@sveinse
Copy link
Contributor

sveinse commented May 19, 2024

With the disclaimer that I didn't write the test mentioned: if an object with a subindex not found it will send the abort code 0x06090011, which the test does, yes. 0x1018:01 is mandatory, but it doesn't make the test invalid.

@acolomb
Copy link
Collaborator

acolomb commented May 23, 2024

I don't see an issue here, please comment if anything needs adjustment, then we can re-open it.

@acolomb acolomb closed this as completed May 23, 2024
@acolomb acolomb closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants