Removed automatic change from NMT BOOTING to NMT PRE-OPERATIONAL #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the if statement for automatically setting the NMT state to pre-operational when the node published a message with the value booting.
|
Why do you think this change is correct? The CANopen standard clearly defines that a node enters the PRE-OPERATIONAL state automatically, right after sending its boot-up message (section 7.3.2.2.1). So I think the previous behavior is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the if statement for automatically setting the NMT state to pre-operational when the node published a message with the value booting.
Changes
Linked Issue
Fixes #401