add_heartbeat_callback is misspelled #389
Comments
acolomb
added a commit
to acolomb/canopen
that referenced
this issue
Jun 4, 2024
Rename the misspelled NmtMaster.add_hearbeat_callback() function to add_heartbeat_callback, with an assignment for the legacy name to not break compatibility in an unexpected manner. Adjust parameter / function documentation and local variables with the same typo consistently.
acolomb
added a commit
that referenced
this issue
Jun 4, 2024
Rename the misspelled NmtMaster.add_hearbeat_callback() function to add_heartbeat_callback, with an assignment for the legacy name to not break compatibility in an unexpected manner. Adjust parameter / function documentation and local variables with the same typo consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the function is called
add_hearbeat_callback(note the missing t in heart.) Might be best to rename and add an alias to the old one so that people's code doesn't break?Thanks for the library!
The text was updated successfully, but these errors were encountered: