-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObfuscatedString: Inconsistent conversion error handling between toCharArray() and toString #20
Comments
Thank you very much for reporting this! The difference in error handling is unintentional. Before changing something however, I wonder what the impact is? ObfuscatedString is designed to be used for string constants in the code. Would the compiler even let you enter some undecodable character sequences in a source file? I don't think so, but I can't prove it, of course.� I'm tending to think that any change should throw a RuntimeException in this case. |
I tend to agree with your point of view. But since in principal the long array contents could be (presumably unintentionally) modified afterwards or when the long array data is transported (with possible transport errors) and unpacked later, there could be encoding errors due to such modifications. So would you be fine with considering a pull request that would change the semantics of |
Sounds fine! I would need some copyright waiver however, but I'm honestly not prepared for that. :-) Your explanation would even suggest some kind of |
Let me know what I precisely would need to do to meet your copyright criteria or whether you would prefer to implement it yourself. I'm expecting the necessary code changes to be rather small, would that still require an additional formalism? Other projects where had provided contributions to do typically have a gray zone where sufficiently small changes don't require a copyright waiver. But I'm not speaking against such a formal agreement. |
Please allow for time to check out the options. This is not exactly top priority right now. |
I have set up a simple CLA process now. Please proceed and submit your pull request. You will be asked to sign a CLA. Don't worry, it's really simple. Thanks in advance for your contribution. |
Class
ObfuscatedString
provides basically two ways to retrieve its obfuscated string data (for good reasons): Either (and traditionally) via it'stoString
method or via itstoCharArray()
. This two-fold API is nicely designed, but it turns out that both methods do use different error handling strategies:toString
is implemented by means of evaluatingString.String(byte[] bytes, int offset, int length, Charset charset)
, which is specified such that malformed-input and unmappable-character sequences are replaced by the charset's default replacement string. Contrary to thistoCharArray()
is implemented by creating a freshCharsetDecorder
usingCharset.newDecoder()
, where the specification tells us:I'm wondering about the different error handling strategies: First, is this difference really intended? It looks astonishing on the first sight. Assuming that it is intended, I would feel that at least a second way should be provided that creates a String by means of a byte[]->char[] conversion which would also report above sort of errors (e.g.
toStringChecked
), possibly also atoCharArrayUnchecked
.If agreement exists to at least some of the suggested changes, I'm willing to provide a corresponding pull request.
If no consensus exists for any code changes, I think the semantic difference between both methods should be clearly documented.
The text was updated successfully, but these errors were encountered: