Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome :-) #1

Open
neocarto opened this issue Jun 29, 2023 · 6 comments
Open

Awesome :-) #1

neocarto opened this issue Jun 29, 2023 · 6 comments

Comments

@neocarto
Copy link

Awesome. Do you plan to make it available in Observable? Actually, we absolutely need that! In any case, i'm available for testing.

@chrispahm
Copy link
Owner

Hi @neocarto 😊

Good call about Observable, I just published a notebook that can be forked/or imported:
https://observablehq.com/@chrispahm/hello-geos-wasm

What are you planning to use it for? Are there certain GEOS functions that you need?

@neocarto
Copy link
Author

neocarto commented Jun 30, 2023

Hi :-) In R, the spatial ecosystem is based on geos, gdal and proj4. I think we need to be able to do the same in the javascript. So I think that geos is essential and that we should gradually move towards a complete port. In the context of Observable notebooks, I don't think the weight of the lib is a problem.

Unfortunately, I don't have the skills to do this job. I'll try to get started, but first I'll have to understand what you've done.

See also https://observablehq.com/@neocartocnrs/geos-wasm

@chrispahm
Copy link
Owner

Hey @neocarto,

I just updated the package to include all GEOS functions. As a result of the discussion in #5 this library now just exposes the low-level C-API without any high-level wrapper functions (unlike e.g. shapely or turf).

After reading the blog post from @kylebarron, and also seeing his demo of GeoRust + GeoArrow I'm also sold on his vision of using the Arrow format and GeoRust in the future! So most certainly I won't be putting too much effort into a potential "Shapely.js", and instead wait for geoarrow-rs to mature 😊 I'd also like to contribute but I don't know Rust so there's that...

Anyways, this repo felt like unfinished business, so I thought at least I'd need to bring it to a state where it can be used if desired. That work is mostly finished now, and I've updated the Observable notebook, as well as the API documentation accordingly. There's also a number of test cases that mostly show how the individual functions can be used.

@kylebarron
Copy link

I'd also like to contribute but I don't know Rust so there's that...

I'm happy to provide tips and point you to easy first PRs if Rust is something you want to learn!

@chrispahm
Copy link
Owner

Yes would definitely be interested in that!

@kylebarron
Copy link

I made stubs at geoarrow/geoarrow-rs#104 and geoarrow/geoarrow-rs#105, where we can discuss good first issues. I haven't given much thought yet to what are some simpler tasks that are good for intro to rust folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants