Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backward incompatible change in github.com/xitongsys/parquet-go #195

Open
mschneider82 opened this issue Jan 19, 2021 · 1 comment
Open

Comments

@mschneider82
Copy link
Contributor

mschneider82 commented Jan 19, 2021

% go build                                                                                                                  
# github.com/chrislusf/gleam/plugins/file/parquet
../../go/pkg/mod/github.com/chrislusf/gleam@v0.0.0-20201128110619-d48afd638bae/plugins/file/parquet/parquet_file_reader.go:8:2: imported and not used: "github.com/xitongsys/parquet-go/types"
../../go/pkg/mod/github.com/chrislusf/gleam@v0.0.0-20201128110619-d48afd638bae/plugins/file/parquet/parquet_file_reader.go:73:29: undefined: ParquetTypeToGoType

it seems in v1.6.0 that functions was removed.
Doing go get -u github.com/xitongsys/parquet-go@v1.5.4 solves the problem for me, but it would be better if gleam had some go.mod file

@xitongsys breaking API Changes should be done in a v2 version, doing it in v1 will break every thing. please see https://blog.golang.org/v2-go-modules

mschneider82 added a commit to mschneider82/gleam that referenced this issue Jan 19, 2021
@chrislusf
Copy link
Owner

@xitongsys could you please help (again) on updating the parquet APIs? It will be nice not to be fixed to an old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants